fix(scripting): fix hotreload when renaming agents.#286
Open
fix(scripting): fix hotreload when renaming agents.#286
Conversation
|
@patwlan Okay, I will respond as soon as possible. Have a nice day! |
|
hey @patwlan should we need 'Remove Agent' Event, or does it expand the bug's scope? |
Contributor
Author
|
Sorry, i keep missing the notifications events on this ticket. 'Remove Agent' Event sounds good. Would you be interested in adding that, @brkeudunman? |
|
@patwlan Yes of course I would like to! I'm also studying MsC while working, so there can be little time for me to contribute. It could take a while 😢 |
Contributor
Author
|
No problem at all. We appreciate any and all help! And good luck with your MsC!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @brkeudunman,
looks liked we merged your PR to quickly. Your assessment of the bug is correct.
Just cleaning the agents at that place in the code causes previously loaded agents to also be removed.
I started this PR that should hopefully address the issue.
It is still WIP, so your feedback and/or help would be appreciated.
Thanks.